Re: [PARPORT] Patch: 2.3.99pre8-lp.c Report Printer Status

From: Tim Waugh (twaugh@redhat.com)
Date: Thu May 18 2000 - 06:26:31 EDT

  • Next message: Tim Waugh: "Re: [PARPORT] vmware, EPP, ECP, ZIP drive, printer port"

    On Wed, May 17, 2000 at 09:13:14PM +0200, Gunther Mayer wrote:

    > But in 2.3.99 LP_NO_ERROR is not even used !?

    I just took a look at this. Does this patch make things any better?

    Tim.
    */

    Index: drivers/char/lp.c
    ===================================================================
    RCS file: /usr/local/src/cvsroot/linux/drivers/char/lp.c,v
    retrieving revision 1.21
    diff -d -u -r1.21 lp.c
    --- drivers/char/lp.c 2000/02/24 09:38:30 1.21
    +++ drivers/char/lp.c 2000/05/18 10:25:33
    @@ -146,13 +146,6 @@
     
     static unsigned int lp_count = 0;
     
    -/* Test if printer is ready */
    -#define LP_READY(status) ((status) & LP_PBUSY)
    -/* Test if the printer is not acking the strobe */
    -#define LP_NO_ACKING(status) ((status) & LP_PACK)
    -/* Test if the printer has error conditions */
    -#define LP_NO_ERROR(status) ((status) & LP_PERRORP)
    -
     #undef LP_DEBUG
     
     /* --- low-level port access ----------------------------------- */
    @@ -265,6 +258,7 @@
             parport_set_timeout (lp_table[minor].dev,
                                  lp_table[minor].timeout);
     
    + if ((retv = lp_check_status (minor)) == 0)
             do {
                     /* Write the data. */
                     written = parport_write (port, kbuf, copy_size);



    -- To unsubscribe, send mail to: linux-parport-request@torque.net --
    -- with the single word "unsubscribe" in the body of the message. --



    This archive was generated by hypermail 2b29 : Thu May 18 2000 - 06:40:02 EDT