[PARPORT] Re: 2.2.17pre3 parport_share SMP locking

From: Tim Waugh (twaugh@redhat.com)
Date: Mon Jun 19 2000 - 08:11:30 EDT

  • Next message: Paweł Krawczyk: "Re: [PARPORT] Compaq Armada parallel"

    On Sat, Jun 17, 2000 at 05:47:14PM +0200, Andrea Arcangeli wrote:

    > These ones doesn't seems to be necessary:
    >
    > @@ -336,14 +371,17 @@
    > struct parport *port = dev->port;
    > unsigned long flags;
    >
    > + read_lock_irqsave (&port->cad_lock, flags);
    > if (port->cad == dev) {
    > + read_unlock_irqrestore (&port->cad_lock, flags);
    > printk(KERN_INFO "%s: %s already owner\n",
    > dev->port->name,dev->name);
    > return 0;
    > }
    > + read_unlock_irqrestore (&port->cad_lock, flags);

    Indeed. I'll take them out when I change that code next.

    First I have to figure out why the parport spin lock changes
    completely break 2.2 for some people but 2.4 seems to work. Looks
    like I'm trying to lock a locked lock or something.

    I've asked Alan to back out all of those changes for 2.2: better to
    have a tiny race than an unavoidable hang. I need to look more
    closely to see what's going on.

    Tim.
    */



    -- To unsubscribe, send mail to: linux-parport-request@torque.net --
    -- with the single word "unsubscribe" in the body of the message. --



    This archive was generated by hypermail 2b29 : Mon Jun 19 2000 - 08:13:31 EDT