Re: [PARPORT] User-space driver causing kernel oops in 2.4.0-test2

From: Tim Waugh (twaugh@redhat.com)
Date: Tue Jul 11 2000 - 11:19:10 EDT

  • Next message: Michael Pal: "[PARPORT] Re: Agfa Scanner"

    On Tue, Jul 11, 2000 at 04:49:42PM +0200, Jan Prikryl wrote:

    > Here you are. Thanks.

    I think this will fix it.

    I am about to change this code though; if you would like to test the
    newer code out, it's at
    <URL:ftp://people.redhat.com/twaugh/patches/patch-cvs-tmw.gz>.

    Tim.
    */

    --- linux-2.4.0-test3-pre8/drivers/char/ppdev.c~ Tue Jul 11 16:14:53 2000
    +++ linux-2.4.0-test3-pre8/drivers/char/ppdev.c Tue Jul 11 16:15:15 2000
    @@ -289,14 +289,14 @@
             ports = pp_port_list;
             while (ports && ports->port->number != minor)
                     ports = ports->next;
    - if (ports->port) {
    + if (ports) {
                     fl = (pp->flags & PP_EXCL) ? PARPORT_FLAG_EXCL : 0;
                     pdev = parport_register_device (ports->port, name, NULL,
                                                     NULL, pp_irq, fl, pp);
             }
             up (&pp_port_list_lock);
     
    - if (!ports->port) {
    + if (!ports) {
                     printk (KERN_WARNING "%s: no associated port!\n", name);
                     kfree (name);
                     return -ENXIO;

    -- To unsubscribe, send mail to: linux-parport-request@torque.net --
    -- with the single word "unsubscribe" in the body of the message. --

    This archive was generated by hypermail 2b29 : Tue Jul 11 2000 - 11:22:33 EDT