On Fri, Nov 03, 2000 at 12:56:33PM +0000, Dr. Peter Cherriman wrote:
> This error message is similar to what I used to get. The patch Tim
> and myself worked out, fixed the problem I was having. Has this
> patch being incorporated into either the 2.2.x or 2.4.x yet?
2.4 only. Here's an untested backport to 2.2.17. There is one more
change from 2.4 to backport though. I'll put this on my list.
Tim.
*/
--- linux/drivers/scsi/ppa.c.pjc Fri Nov 3 13:09:59 2000
+++ linux/drivers/scsi/ppa.c Fri Nov 3 13:11:39 2000
@@ -298,6 +298,7 @@
unsigned short ppb = PPA_BASE(host_no);
unsigned char r;
+ /* Wait for bit 6 and 7 - PJC */
k = PPA_SPIN_TMO;
do {
r = r_str(ppb);
@@ -653,11 +654,7 @@
(v == WRITE_6) ||
(v == WRITE_10));
- /*
- * We only get here if the drive is ready to comunicate,
- * hence no need for a full ppa_wait.
- */
- r = (r_str(ppb) & 0xf0);
+ r = ppa_wait(host_no); /* Need a ppa_wait() - PJC */
while (r != (unsigned char) 0xf0) {
/*
@@ -695,7 +692,7 @@
}
}
/* Now check to see if the drive is ready to comunicate */
- r = (r_str(ppb) & 0xf0);
+ r = ppa_wait(host_no); /* need ppa_wait() - PJC */
/* If not, drop back down to the scheduler and wait a timer tick */
if (!(r & 0x80))
return 0;
--- linux/drivers/scsi/ppa.h.pjc Fri Nov 3 13:11:44 2000
+++ linux/drivers/scsi/ppa.h Fri Nov 3 13:13:34 2000
@@ -10,7 +10,7 @@
#ifndef _PPA_H
#define _PPA_H
-#define PPA_VERSION "2.03 (for Linux 2.2.x)"
+#define PPA_VERSION "2.04 (for Linux 2.2.x)"
/*
* this driver has been hacked by Matteo Frigo (athena@theory.lcs.mit.edu)
@@ -51,6 +51,12 @@
* CONFIG_SCSI_PPA_HAVE_PEDANTIC => CONFIG_SCSI_IZIP_EPP16
* added CONFIG_SCSI_IZIP_SLOW_CTR option
* [2.03]
+ *
+ * Use ppa_wait() to check for ready AND connected status bits
+ * Add ppa_wait() calls to ppa_completion()
+ * by Peter Cherriman <pjc@ecs.soton.ac.uk> and
+ * Tim Waugh <twaugh@redhat.com>
+ * [2.04]
*/
/* ------ END OF USER CONFIGURABLE PARAMETERS ----- */
-- To unsubscribe, send mail to: linux-parport-request@torque.net --
-- with the single word "unsubscribe" in the body of the message. --
This archive was generated by hypermail 2b29 : Fri Nov 03 2000 - 08:18:54 EST