Re: [PARPORT] simple driver

From: Philip Blundell (philb@gnu.org)
Date: Wed Apr 11 2001 - 10:48:36 EDT

  • Next message: Aditya Mittal: "Re: [PARPORT] simple driver"

    >read_write_t scope_write(struct inode *inode, struct file *filp,
    > const char *buf, count_t count)
    >{

    What version of the kernel are you using? That kind of write() signature
    hasn't been appropriate since 2.0 or so. Also:

    > copy_from_user(kbuf, buf, count);

    This function returns an error flag; you ought to check for success. Also:

    > outb(*(ptr++),port);

    It would probably be better to use the parport functions rather than
    attacking the bare metal directly, though that's a matter of choice.

    p.

    -- To unsubscribe, send mail to: linux-parport-request@torque.net --
    -- with the single word "unsubscribe" in the body of the message. --



    This archive was generated by hypermail 2b29 : Wed Apr 11 2001 - 10:54:29 EDT