Re: [PARPORT] patch-2.1.91pre2-parport980327


Andrea Arcangeli (arcangeli@mbox.queen.it)
Tue, 31 Mar 1998 16:44:35 +0200 (CEST)


On Fri, 27 Mar 1998, Tim Waugh wrote:

>Hi guys,
>
>Please try out this patch:
>
><ftp://ftp.torque.net/pub/parport/patch-2.1.91pre2-parport980327>

The patch seems to be mainly wrong. It is completly wrong define the
lp flags inside parport.h. These flags give us the semantic of how _lp_
handle the 8255 signal lines. How can be useful PARPORT_STATUS_PAPEROUT
for a parallel ZIP drive for example?

All parport_timedout() macro should be also moved into lp.h and all must
be renamed from PARPORT_xxx and parport_xxx to LP_xxx and lp_xxx.

This only after a short read of the patch...

Andrea[s] Arcangeli

-- To unsubscribe, send mail to: linux-parport-request@torque.net --
-- with the single word "unsubscribe" in the body of the message. --



This archive was generated by hypermail 2.0b3 on Wed 30 Dec 1998 - 10:17:34 EST