[PARPORT] Re: patch-2.1.131-ac8-1284

Tim Waugh (tim@cyberelk.demon.co.uk)
Mon, 14 Dec 1998 19:57:35 +0000 (GMT)

On Mon, 14 Dec 1998, Andrea Arcangeli wrote:

> Without this patch I dubit that the new lp (that uses 1284 functions)
> would not cause an Oops using parport_ax or _arc. An alternative patch
> would be to add a check for null in read_block() and write_block() in
> parport_ieee1284.c but I think it would only decrease performance because
> such functions are likely to exists...

I'm not sure about this. If you look at the char drivers, they have NULL
for functions they don't want to implement. I think maybe it should be
the same thing here, and parport_ieee1284.c should be changed. I'll think
a bit more about it.

> Little cleanup/improvement:

Thanks, applied.

> This patch will implement a policy where the ieee_ops lowlevel function
> has to be called with a callback not null. This will improve performance
> because ~always there' s a valid callback set.

Not sure about this one either. The saving isn't exactly colossal. ;-)

> I just included patch-2.1.131-ac8-1284 + the patches above in my arca-tree
> to handle more testing from people on more hardware...

Okay. Are you planning to merge your arca tree into 2.2 though?

> Tim and what about things like tunelp -w now?

Um. What does tunelp -w do? ;-)


-- To unsubscribe, send mail to: linux-parport-request@torque.net --
-- with the single word "unsubscribe" in the body of the message. --

This archive was generated by hypermail 2.0b3 on Wed 30 Dec 1998 - 10:18:54 EST