[PARPORT] RE: patch-2.1.131-ac11-1284-2


Andrea Arcangeli (andrea@e-mind.com)
Wed, 16 Dec 1998 19:31:38 +0100 (CET)


On Wed, 16 Dec 1998, Andrea Arcangeli wrote:

>Hmm yes probably is better to resolve the macro in the source code ;)

Index: drivers/char/lp.c
===================================================================
RCS file: /var/cvs/linux/drivers/char/lp.c,v
retrieving revision 1.1.1.1.2.4
diff -u -r1.1.1.1.2.4 lp.c
--- lp.c 1998/12/16 14:18:26 1.1.1.1.2.4
+++ lp.c 1998/12/16 18:29:43
@@ -193,12 +193,6 @@
         wakeup_err_waitq(&lp_dev->err_waitq);
 }
 
-#define REVERT_TO_POLLING \
-do { \
- sti(); \
- goto polling; \
-} while (0)
-
 static void lp_error (int minor)
 {
         int polled;
@@ -221,9 +215,14 @@
                         interruptible_sleep_on_timeout (LP_ERR_WAITQ(minor),
                                                         LP_TIMEOUT_INTERRUPT);
                         if (LP_PREEMPTED(minor))
- REVERT_TO_POLLING;
- } else
- REVERT_TO_POLLING;
+ {
+ sti();
+ goto polling;
+ }
+ } else {
+ sti();
+ goto polling;
+ }
                 sti();
         }
 }

Andrea Arcangeli

-- To unsubscribe, send mail to: linux-parport-request@torque.net --
-- with the single word "unsubscribe" in the body of the message. --



This archive was generated by hypermail 2.0b3 on Wed 30 Dec 1998 - 10:18:57 EST