Re: [PARPORT] patch-2.2.3-tmw9


Tim Waugh (tim@cyberelk.demon.co.uk)
Sat, 20 Mar 1999 15:09:25 +0000 (GMT)


On Sat, 20 Mar 1999, Philip Blundell wrote:

> Actually, it looks like the reason I wasn't getting any lp readback data was
> because of a bug in the negotiation code. See what you think to this patch.

> - if (!xflag || !mode) {
> + if (mode && !xflag) {

I don't think that's any better, but you're right that it's incorrect
still. Damn C's shortcut evaluation.

How about this:

- if (!xflag || !mode) {
+ if ((!mode && xflag) || (mode && !xflag)) {

Tim.
*/

-- To unsubscribe, send mail to: linux-parport-request@torque.net --
-- with the single word "unsubscribe" in the body of the message. --



This archive was generated by hypermail 2.0b3 on Sun 28 Mar 1999 - 17:04:19 EST