Re: [PARPORT] Patch: 2.3.99pre8-lp.c Report Printer Status

From: Philip Blundell (Philip.Blundell@pobox.com)
Date: Mon May 15 2000 - 15:38:00 EDT

  • Next message: Tim Waugh: "Re: [PARPORT] Patch: 2.3.99pre8-lp.c Report Printer Status"

    >Try switching if off-line (this happens with printers where people walk by...),
    >no printing, no messages.

    It looks to me like the old code should have handled the `offline' case.

            } else if (!(status & LP_PSELECD)) {
                    if (last != LP_PSELECD) {
                            last = LP_PSELECD;
                            printk(KERN_INFO "lp%d off-line\n", minor);
                    }
                    error = -EIO;

    Can you explain why this wasn't happening for you? (I can't test it right
    now.)

    >Third, LP_CAREFUL made matter just more complicated, so I removed
    >this old cruft (Linus always demands removing cruft instead of adding
    >workarounds).

    I agree that LP_CAREFUL is no longer useful. Once upon a time it actually
    affected the semantics of printing, not just error reporting. You should
    probably also make the LPCAREFUL ioctl print a warning message.

    p.

    -- To unsubscribe, send mail to: linux-parport-request@torque.net --
    -- with the single word "unsubscribe" in the body of the message. --



    This archive was generated by hypermail 2b29 : Mon May 15 2000 - 14:43:24 EDT