Re: [PARPORT] sneak preview


Philip Blundell (Philip.Blundell@pobox.com)
Sun, 30 Nov 1997 23:26:32 +0000


>Here the patch against your' s. Your patch add a bug in the use of
>reuquest/free irq in parport_share.c. I hope to see it in 2.1.68.

Here's a patch to fix that - does it work for you? I'll take a look at the
rest of your patch tomorrow; thanks.

p.

RCS file: /vger/u4/cvs/linux/drivers/misc/parport_share.c,v
retrieving revision 1.8
diff -u -r1.8 parport_share.c
--- parport_share.c 1997/11/08 18:55:29 1.8
+++ parport_share.c 1997/11/30 22:23:11
@@ -279,7 +279,7 @@

        /* Swap the IRQ handlers. */
        if (dev->port->irq != PARPORT_IRQ_NONE) {
- free_irq(dev->port->irq, dev->port);
+ free_irq(dev->port->irq, pd1?pd1->private:NULL);
                request_irq(dev->port->irq, dev->irq_func ? dev->irq_func :
                            parport_null_intr_func, SA_INTERRUPT, dev->name,
                            dev->private);
@@ -307,7 +307,7 @@

        /* Point IRQs somewhere harmless. */
        if (dev->port->irq != PARPORT_IRQ_NONE) {
- free_irq(dev->port->irq, dev->port);
+ free_irq(dev->port->irq, dev->private);
                request_irq(dev->port->irq, parport_null_intr_func,
                            SA_INTERRUPT, dev->port->name, NULL);
        }

-- To unsubscribe, send mail to: linux-parport-request@torque.net --
-- with the single word "unsubscribe" in the body of the message. --



This archive was generated by hypermail 2.0b3 on Wed 30 Dec 1998 - 10:17:08 EST