Andrea Arcangeli (arcangeli@mbox.queen.it)
Sat, 20 Dec 1997 17:56:35 +0100 (CET)
On Sun, 14 Dec 1997, Philip Blundell wrote:
>Hi.
>
>I did some cosmetic surgery on the lp driver. In theory all the PC-specific
>port access code is gone now, and parameters (both module and kernel) should
>work properly now.
>
>The patch is appended. As with all great changes, I haven't tested it at all
>(due to not having a machine to do so on right now). It compiles OK, though -
>please check it out.
>
>p.
>
A little fix:
--- linux/drivers/char/lp.c 1997/12/20 15:14:04 1.2
+++ linux/drivers/char/lp.c 1997/12/20 16:52:43 1.3
@@ -676,7 +676,7 @@
#endif
-int lp_register(int nr, struct parport *port)
+void lp_register(int nr, struct parport *port)
{
lp_table[nr].dev = parport_register_device(port, "lp",
lp_preempt, lp_wakeup,
@@ -693,8 +693,6 @@
lp_parport_release(nr);
printk(KERN_INFO "lp%d: using %s (%s).\n", nr, port->name,
(port->irq == PARPORT_IRQ_NONE)?"polling":"interrupt-driven");
-
- return 0;
}
int lp_init(void)
@@ -715,9 +713,9 @@
port->probe_info.class != PARPORT_CLASS_PRINTER)
continue;
- if (lp_register(count, port))
- if (++count == LP_NO)
- break;
+ lp_register(count, port);
+ if (++count == LP_NO)
+ break;
}
break;
Andrea[s] Arcangeli
-- To unsubscribe, send mail to: linux-parport-request@torque.net --
-- with the single word "unsubscribe" in the body of the message. --
This archive was generated by hypermail 2.0b3 on Wed 30 Dec 1998 - 10:17:12 EST