Re: [PARPORT] parport_pc revisited


Andrea Arcangeli (arcangeli@mbox.queen.it)
Sat, 20 Dec 1997 16:31:44 +0100 (CET)


On Tue, 16 Dec 1997, Philip Blundell wrote:

>Hi.
>
>People complained that the last patch didn't apply cleanly. Here's a new one.
>
>p.

You reverted to the bugged request_irq/free_irq dev_id.

--- parport_pc.c 1997/12/20 15:16:36 1.2
+++ parport_pc.c 1997/12/20 15:28:33 1.3
@@ -164,7 +164,7 @@
 void parport_pc_release_resources(struct parport *p)
 {
         if (p->irq != PARPORT_IRQ_NONE)
- free_irq(p->irq, p);
+ free_irq(p->irq, NULL);
         release_region(p->base, p->size);
         if (p->modes & PARPORT_MODE_PCECR)
                 release_region(p->base+0x400, 3);
@@ -174,7 +174,7 @@
 {
         /* FIXME check that resources are free */
         if (p->irq != PARPORT_IRQ_NONE)
- request_irq(p->irq, parport_pc_null_intr_func, 0, p->name, p);
+ request_irq(p->irq, parport_pc_null_intr_func, 0, p->name, NULL);
         request_region(p->base, p->size, p->name);
         if (p->modes & PARPORT_MODE_PCECR)
                 request_region(p->base+0x400, 3, p->name);

Andrea[s] Arcangeli

-- To unsubscribe, send mail to: linux-parport-request@torque.net --
-- with the single word "unsubscribe" in the body of the message. --



This archive was generated by hypermail 2.0b3 on Wed 30 Dec 1998 - 10:17:12 EST