Re: [PARPORT] parport-diff-980103.gz

Andrea Arcangeli (
Sun, 4 Jan 1998 02:02:55 +0100 (CET)

On Sat, 3 Jan 1998, Philip Blundell wrote:

>This version has a rewritten version of the new scheduling code that should be
>more robust, and the appropriate fixes to lp.c so it apparently actually works

Woops, I forget to ask you why to add these lines at the end of

       /* Nobody was waiting, so walk the list to see if anyone is
          interested in being woken up. */
       for (pd = port->devices; (port->cad == NULL) && pd; pd = pd->next)

               if (pd->wakeup)

This additional waking up should be not needed. I think that is better
remove this, in order to break things if something goes wrong in the
_real_ scheduling code and eventually fix it.

We _could_ also take a look at the (pd->waiting & 1) for a more paranoid

980103 don' t apply clean to 2.1.77 in linux/Documentation/
that Hunk #1 succeeded at 1170 with fuzz 2 (offset 202 lines)).
You forgotten:

+++ linux/include/linux/lp.h Thu Jan 1 07:29:27 1998
+++ linux/include/linux/parport.h Thu Jan 1 07:29:36 1998
+++ linux/include/linux/parport_pc.h Tue Dec 30 13:57:13 1997

Andrea[s] Arcangeli

-- To unsubscribe, send mail to: --
-- with the single word "unsubscribe" in the body of the message. --

This archive was generated by hypermail 2.0b3 on Wed 30 Dec 1998 - 10:17:18 EST