Re: [PARPORT] patch-2.1.91pre2-parport980327

Andrea Arcangeli (
Tue, 31 Mar 1998 18:09:44 +0200 (CEST)

On Tue, 31 Mar 1998, Andrea Arcangeli wrote:

>On Tue, 31 Mar 1998, Andrea Arcangeli wrote:
>>On Fri, 27 Mar 1998, Tim Waugh wrote:
>>>Hi guys,
>>>Please try out this patch:
>>The patch seems to be mainly wrong. It is completly wrong define the
>>lp flags inside parport.h. These flags give us the semantic of how _lp_
>>handle the 8255 signal lines. How can be useful PARPORT_STATUS_PAPEROUT
>>for a parallel ZIP drive for example?
>>All parport_timedout() macro should be also moved into lp.h and all must
>>be renamed from PARPORT_xxx and parport_xxx to LP_xxx and lp_xxx.
>>This only after a short read of the patch...
>The irq_write_proc() patch in parport_procfs.c is broken too.

Again the status file in the parport proc tree make no sense. If you like
it you must add it in a lp proc tree as ppa just does:

andrea@dragon:~$ cat /proc/scsi/ppa/0
Version : 1.39a
Parport : parport0
Mode : EPP 32 bit
andrea@dragon:~$ cat /proc/parport/0/devices

BTW, I just noticed that PARPORT_STATUS_PAPEROUT just exists before the
patch in parport.h. It make no sense and infact it is not used ;-).

andrea@dragon:~$ find /usr/src/linux/ -name \*.[ch] -exec grep -l PAPEROUT {} \;
andrea@dragon:~$ grep PAPEROUT /usr/src/linux/include/linux/parport.h
andrea@dragon:~$ head -3 /usr/src/linux/Makefile

(it' s 92pre2).

Andrea[s] Arcangeli

-- To unsubscribe, send mail to: --
-- with the single word "unsubscribe" in the body of the message. --

This archive was generated by hypermail 2.0b3 on Wed 30 Dec 1998 - 10:17:34 EST