[PARPORT] Re: for people with printing problems with 2.1.104


Andrea Arcangeli (arcangeli@mbox.queen.it)
Wed, 27 May 1998 16:43:43 +0200 (CEST)


On Wed, 27 May 1998, Andrea Arcangeli wrote:

>I will sent to Andreas some debugging patch soon to understand at least if
>the bug is in the parallel-port or in the parport code.

Looking at the parport_pc code seems that we are initializing the ECR even
if the ECR is not been detected.

This patch should fix that.

--- linux/drivers/misc/parport_pc.c 1998/04/25 10:38:34 1.1
+++ linux/drivers/misc/parport_pc.c 1998/05/27 14:38:57
@@ -708,7 +708,8 @@
         p->flags |= PARPORT_FLAG_COMA;
 
         /* Done probing. Now put the port into a sensible start-up state. */
- parport_pc_write_econtrol(p, 0xc);
+ if (p->modes & PARPORT_MODE_PCECR)
+ parport_pc_write_econtrol(p, 0xc);
         parport_pc_write_control(p, 0xc);
         parport_pc_write_data(p, 0);

I' ll try to sent to Muck a patch that put econtrol to 0 to disable ECP
enable bit and ECP service bit hoping that this will help him.
 
Andrea[s] Arcangeli

-- To unsubscribe, send mail to: linux-parport-request@torque.net --
-- with the single word "unsubscribe" in the body of the message. --



This archive was generated by hypermail 2.0b3 on Wed 30 Dec 1998 - 10:17:47 EST