Tim Waugh (tim@cyberelk.demon.co.uk)
Tue, 29 Sep 1998 22:31:54 +0100 (BST)
Hi Linus,
Just spotted this - typo in parport.h. The parport_yield functions are
supposed to return the same as the parport_claim functions. One of the
possible return values is -EAGAIN, so returning an unsigned int is a
little silly.
Currently the only use of parport_yield in the kernel is in lp.c, and it's
just tested against zero.
Tim.
*/
--- include/linux/parport.h.orig Tue Sep 29 22:25:43 1998
+++ include/linux/parport.h Tue Sep 29 22:27:11 1998
@@ -273,7 +273,7 @@
/* parport_yield relinquishes the port if it would be helpful to other
* drivers. The return value is the same as for parport_claim.
*/
-extern __inline__ unsigned int parport_yield(struct pardevice *dev)
+extern __inline__ int parport_yield(struct pardevice *dev)
{
unsigned long int timeslip = (jiffies - dev->time);
if ((dev->port->waithead == NULL) || (timeslip < dev->timeslice))
@@ -285,7 +285,7 @@
/* parport_yield_blocking is the same but uses parport_claim_or_block
* instead of parport_claim.
*/
-extern __inline__ unsigned int parport_yield_blocking(struct pardevice *dev)
+extern __inline__ int parport_yield_blocking(struct pardevice *dev)
{
unsigned long int timeslip = (jiffies - dev->time);
if ((dev->port->waithead == NULL) || (timeslip < dev->timeslice))
-- To unsubscribe, send mail to: linux-parport-request@torque.net --
-- with the single word "unsubscribe" in the body of the message. --
This archive was generated by hypermail 2.0b3 on Wed 30 Dec 1998 - 10:18:27 EST