Re: [PARPORT] ECP + other bug fixed to parport driver


Jamie Lokier (jamie.lokier@cern.ch)
Sun, 26 Sep 1999 22:04:18 +0200


Tim Waugh wrote:
[wrt. __frob_control]
> > I assume the reason for having explicit out of line copies of the
> > other functions is in case you load the parport_pc module, having
> > compiled other modules with CONFIG_PARPORT_OTHER.
>
> Yes, basically, but also in case gcc decides not to inline _those_
> functions (even if it decided to inline outb).

Currently it will _always_ inline functions declared `inline', if
optimisation is on. That means the out of line ones are simply wasting
space.

How about declaring __frob_control `static inline', which gives the
assurance that things will work if the compiler strategy changes, but
doesn't waste space given how we know things are at the moment?

-- Jamie

-- To unsubscribe, send mail to: linux-parport-request@torque.net --
-- with the single word "unsubscribe" in the body of the message. --



This archive was generated by hypermail 2.0b3 on Sun 26 Sep 1999 - 16:07:43 EDT