Re: [PARPORT] PATCH: parport MODULE_DEVICE_TABLE proposal for modutils and kernel v1.0

From: Adam J. Richter (
Date: Sat Dec 16 2000 - 11:47:46 EST

  • Next message: Tim Waugh: "Re: [PARPORT] IDE Flash disk"

    On Sat, Dec 16, 2000 at 12:32:20PM +0000, Tim Waugh wrote:
    >On Fri, Dec 15, 2000 at 03:35:00PM -0800, Adam J. Richter wrote:

    >> +struct parport_device_id {
    >> + const char *pattern; /* must be all lower case */
    >> +}; /* Normally, a string will be cast into a pointer to this struct. */

    >This comment should probably say 'pattern is a regexp describing
    >appropriate Device IDs'.

            Oops. That last comment should simply be deleted. We are
    not going to use regular expressions.

    >> +/* printer_ieee1284_id is declared as the its own variable so that it
    > ^^^^
    >(Extra word?)

            Right again.

    >> + { }

    >That's the same as { NULL }, right?

            Yes. Most of the other device ID tables terminate with "{ }"
    (they do not contain pointers), so this is stylistically more consistent.

    >> + fprintf(parptmap, "# module regexp.\n");

    >Are we going with regular expressions, or with a set of glob
    >expressions (one for each relevant key), or with a set of regular
    >expressions (one for each relevant key)? I think I'd prefer globs,

            You're right. That line should be:

            fprintf(parptmap, "# module pattern.\n");

            Keith, can you change your modutils to reflect this last

            I have attached an updated kerenl patch below. Thanks for
    catching my mistakes, Tim.

    Adam J. Richter     __     ______________   4880 Stevens Creek Blvd, Suite 104     \ /                  San Jose, California 95129-1034
    +1 408 261-6630         | g g d r a s i l   United States of America
    fax +1 408 261-6631      "Free Software For The Rest Of Us."

    -- To unsubscribe, send mail to: -- -- with the single word "unsubscribe" in the body of the message. --

    This archive was generated by hypermail 2b29 : Sat Dec 16 2000 - 11:48:33 EST