Re: [PARPORT] PATCH: parport MODULE_DEVICE_TABLE proposal for modutils and kernel v1.0

From: Tim Waugh (tim@cyberelk.demon.co.uk)
Date: Sat Dec 16 2000 - 07:32:20 EST

  • Next message: Petr Olivka: "[PARPORT] IDE Flash disk"

    On Fri, Dec 15, 2000 at 03:35:00PM -0800, Adam J. Richter wrote:

    > +struct parport_device_id {
    > + const char *pattern; /* must be all lower case */
    > +}; /* Normally, a string will be cast into a pointer to this struct. */

    This comment should probably say 'pattern is a regexp describing
    appropriate Device IDs'.

    > +/* printer_ieee1284_id is declared as the its own variable so that it
                                             ^^^^
    (Extra word?)

    > + { }

    That's the same as { NULL }, right?

    > + fprintf(parptmap, "# module regexp.\n");

    Are we going with regular expressions, or with a set of glob
    expressions (one for each relevant key), or with a set of regular
    expressions (one for each relevant key)? I think I'd prefer globs,
    personally.

    Tim.
    */



    -- To unsubscribe, send mail to: linux-parport-request@torque.net --
    -- with the single word "unsubscribe" in the body of the message. --



    This archive was generated by hypermail 2b29 : Sat Dec 16 2000 - 07:36:27 EST